-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4939/
-----------------------------------------------------------
Review request for kde-windows and kdelibs.
Summary
-------
Implements an extension to kio_file KIOSlave to add a "computer:" protocol.
Also reverts changes on "places" panel to show up "Computer" instead of
separated drive letters.
I think it would be risky to change the "file:" protocol directly since some
apps may try to use "/" and that currently "Just works".
Dolphin's "folders" panel also magically works fine when in "computer:"
protocol. When in "file:" it still shows "C:"'s hierarchy only.
Konqueror's sidebar still crashes when using "root" bookmark and not being on
"C:". I've also written a patch for that but it still has a bug: can't access a
subfolder of a drive without accessing that drive first (an open with... dialog
is shown).
(since reviewboard does not accept more than one .diff file it is pasted below)
[on kdebase/apps hierarchy:]
Index: konqueror/sidebar/default_entries/CMakeLists.txt
===================================================================
--- konqueror/sidebar/default_entries/CMakeLists.txt (revision 1151120)
+++ konqueror/sidebar/default_entries/CMakeLists.txt (working copy)
@@ -1,9 +1,25 @@
-install( FILES
- home.desktop
- root.desktop
- bookmarks.desktop
- services.desktop
- remote.desktop
- history.desktop
- places.desktop
-DESTINATION ${DATA_INSTALL_DIR}/konqsidebartng/entries )
+if(WIN32)
+
+ install( FILES
+ home.desktop
+ computer.desktop
+ bookmarks.desktop
+ services.desktop
+ remote.desktop
+ history.desktop
+ places.desktop
+ DESTINATION ${DATA_INSTALL_DIR}/konqsidebartng/entries )
+
+else(WIN32)
+
+ install( FILES
+ home.desktop
+ root.desktop
+ bookmarks.desktop
+ services.desktop
+ remote.desktop
+ history.desktop
+ places.desktop
+ DESTINATION ${DATA_INSTALL_DIR}/konqsidebartng/entries )
+
+endif (WIN32)
\ No newline at end of file
Index: konqueror/sidebar/default_entries/computer.desktop
===================================================================
--- konqueror/sidebar/default_entries/computer.desktop (revision 0)
+++ konqueror/sidebar/default_entries/computer.desktop (revision 0)
@@ -0,0 +1,16 @@
+[Desktop Entry]
+Type=Link
+URL=computer:/
+Icon=computer
+Name=Computer
+Name[en_GB]=Computer
+Name[pt]=Computador
+Name[pt_BR]=Computador
+Comment=This is the place containing the windows drives
+Comment[en_GB]=This is the place containing the windows drives
+Comment[pt]=Este é o local que contém as unidades do windows
+Comment[pt_BR]=Este é o local que contém as unidades do windows
+Open=false
+X-KDE-TreeModule=Directory
+X-KDE-KonqSidebarModule=konqsidebar_tree
+X-KDE-Weight=11
Diffs
-----
trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp 1159835
trunk/KDE/kdelibs/kioslave/file/CMakeLists.txt 1159835
trunk/KDE/kdelibs/kioslave/file/computer.protocol PRE-CREATION
trunk/KDE/kdelibs/kioslave/file/file.h 1159835
trunk/KDE/kdelibs/kioslave/file/file.cpp 1159835
trunk/KDE/kdelibs/kioslave/file/kio_computer.h PRE-CREATION
trunk/KDE/kdelibs/kioslave/file/kio_computer.cpp PRE-CREATION
Diff: http://reviewboard.kde.org/r/4939/diff
Testing
-------
Tested using msvc 2008, windows 7
Screenshots
-----------
dolphin screenshot
http://reviewboard.kde.org/r/4939/s/475/
Thanks,
andrius
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows
