----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6329/#review9621 -----------------------------------------------------------
Ship it! Looks good -- but you probably want to do the same in the %f case. It says url.path() right now, but this should be QDir::toNativeSeparators(url.toLocalFile()) instead. - David On Jan. 13, 2011, 8:36 a.m., TheOneRing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6329/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2011, 8:36 a.m.) > > > Review request for kde-windows and kdelibs. > > > Summary > ------- > > Wen staring a .desktop file translate the %U URL to a native Windows path if > its a local file. > This makes sure that we can start non KDE software. > Starting KDE software works as well. > > > Diffs > ----- > > trunk/KDE/kdelibs/kio/kio/krun.cpp 1208777 > > Diff: http://svn.reviewboard.kde.org/r/6329/diff > > > Testing > ------- > > Tested on mingw-w32 trunk with vlc/kate/gwenview/okular > Tested on msvc10 4.5.4 with vlc > > > Thanks, > > TheOneRing > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
