----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6347/#review9653 -----------------------------------------------------------
Ship it! looks good - Ralf On Jan. 16, 2011, 11:34 p.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6347/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 11:34 p.m.) > > > Review request for kde-windows. > > > Summary > ------- > > *Source.applyPatch: The overriding methods in GitSource, HgSource, > SvnSource should have the same number of arguments as in the > base class. This does not fix a bug, it is just cleaner and makes > pylint happy - and it might prevent future bugs. > > MultiSource.applyPatch() cannot possibly work. So raise an > exception explaining the situation and comment the wrong code. > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/Source/GitSource.py 1214807 > /trunk/kdesupport/emerge/bin/Source/HgSource.py 1214807 > /trunk/kdesupport/emerge/bin/Source/MultiSource.py 1214807 > /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1214807 > /trunk/kdesupport/emerge/bin/Source/SvnSource.py 1214807 > > Diff: http://svn.reviewboard.kde.org/r/6347/diff > > > Testing > ------- > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
