----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6345/#review9654 -----------------------------------------------------------
Ship it! looks good - Ralf On Jan. 16, 2011, 11:28 p.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6345/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 11:28 p.m.) > > > Review request for kde-windows. > > > Summary > ------- > > EmergeBase.__init__: if the object does not yet have attribute > buildSystemType, set it to None. This makes referencing this > attribute easier because "if hasattr()" is no longer needed. And > it makes pylint happy. > The same thing has already been done with subinfo, r1214441, which > resulted in no complaints or problems > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/EmergeBase.py 1214807 > /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1214807 > /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py 1214807 > /trunk/kdesupport/emerge/bin/Source/ArchiveSource.py 1214807 > /trunk/kdesupport/emerge/bin/Source/FileSource.py 1214807 > /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1214807 > > Diff: http://svn.reviewboard.kde.org/r/6345/diff > > > Testing > ------- > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
