----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6486/#review9884 -----------------------------------------------------------
Ship it! looks good - Ralf On Feb. 18, 2011, 8:36 a.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6486/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2011, 8:36 a.m.) > > > Review request for kde-windows. > > > Summary > ------- > > __installedDBPrefix existed identically in PackageBase and > InternalPackageBase. Remove it from InternalPackageBase and rename to > _installedDBPrefix > > rename self.packager to self.packagerExe for consistency > > simplify code in PackagerFactory (this code is actually unused but it looks > like a plan for the future) > > a few other small simplifications around packager code > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/Package/InternalPackageBase.py 1221360 > /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1221360 > /trunk/kdesupport/emerge/bin/Packager/InnoSetupPackager.py 1221360 > /trunk/kdesupport/emerge/bin/Packager/KDEWinPackager.py 1221360 > /trunk/kdesupport/emerge/bin/Packager/PackagerFactory.py 1221360 > /trunk/kdesupport/emerge/bin/Packager/SevenZipPackager.py 1221360 > > Diff: http://svn.reviewboard.kde.org/r/6486/diff > > > Testing > ------- > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
