----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6532/#review9894 -----------------------------------------------------------
The basic idea looks good, but the patch is incomplete. You removed the className parameter but the derived classes in Source, Buildsystem and Packager still provides this parameter. - Ralf On Feb. 20, 2011, 6:27 p.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6532/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2011, 6:27 p.m.) > > > Review request for kde-windows. > > > Summary > ------- > > instead do this dynamically - for the class and all of its ancestors check > if internal dependencies are defined. If > EMERGE_ENABLE_IMPLICID_BUILDTIME_DEPENDENCIES > is set, depend on them. > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py 1221710 > /trunk/kdesupport/emerge/bin/EmergeBase.py 1221711 > /trunk/kdesupport/emerge/bin/Packager/PackagerBase.py 1221710 > /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1221711 > /trunk/kdesupport/emerge/bin/Source/VersionSystemSourceBase.py 1221711 > > Diff: http://svn.reviewboard.kde.org/r/6532/diff > > > Testing > ------- > > if that long shell variable is set, the dependencies are added as before > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
