----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6527/#review9934 -----------------------------------------------------------
Ship it! moving applyPatches looks as a good idea to me. I suggest to add these method to the api screenshots in emerge/doc/refactoring-2009 - Ralf On Feb. 27, 2011, 10:49 p.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6527/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2011, 10:49 p.m.) > > > Review request for kde-windows. > > > Summary > ------- > > simplifies the source code. Make no exception for being called with only one > patch. > Remove warning for failed patch from applyPatches, applyPatch warns. > log a warning if applyPatch is called without a patch file name > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1222425 > /trunk/kdesupport/emerge/bin/utils.py 1222512 > > Diff: http://svn.reviewboard.kde.org/r/6527/diff > > > Testing > ------- > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
