----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6608/#review9992 -----------------------------------------------------------
Ship it! looks good - Ralf On March 11, 2011, 11:45 a.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6608/ > ----------------------------------------------------------- > > (Updated March 11, 2011, 11:45 a.m.) > > > Review request for kde-windows. > > > Summary > ------- > > this is the first of several patches, so the important patch will be as small > as possible. > the ultimate result will be: > - no hanging git when cloning qt > - calling git directly (no MSysShell needed anymore with current git) > - much less clutter in the logfile without MSysShell > > this first patch only has some simple fixes and cleanups. > Especially the number of calls to shell.execute() is reduced. > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/Source/GitSource.py 1224451 > > Diff: http://svn.reviewboard.kde.org/r/6608/diff > > > Testing > ------- > > building qt and kdelibs > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
