> On March 26, 2011, 6:03 p.m., Ralf Habacker wrote: > > in Line 209 there is a difference > > - '-p %d' > > + '-p%d' > > > > otherwise looks good. > > > > Wolfgang Rohdewald wrote: > actually it was -p %s before where %s is a digit. If you look at "man > patch" you will see that they always write -pnum without a space, so I would > say '-p%d' is more correct than '-p %d'
something went wrong here with review publishing - this should be "man patch and patch --help are inconsistent - so put that space back just to be on the safe side". I reported that as a bug: https://bugs.launchpad.net/ubuntu/+source/patch/+bug/743710 - Wolfgang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6613/#review10029 ----------------------------------------------------------- On March 27, 2011, 4:36 p.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6613/ > ----------------------------------------------------------- > > (Updated March 27, 2011, 4:36 p.m.) > > > Review request for kde-windows. > > > Summary > ------- > > - no hanging git when cloning qt > - calling git directly (no MSysShell needed anymore with current git) > - much less clutter in the logfile without MSysShell > > however this does more calls to checkoutDir(). I have one more patch which > caches this within GitSource but it depends on this patch > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/Source/GitSource.py 1225001 > > Diff: http://svn.reviewboard.kde.org/r/6613/diff > > > Testing > ------- > > building qt and kdelibs > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
