----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102468/#review6106 -----------------------------------------------------------
Ship it! Looks very good. - Patrick On Aug. 28, 2011, 8:27 a.m., Yury Georgievich Kudryashov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102468/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2011, 8:27 a.m.) > > > Review request for kdewin and Soprano. > > > Summary > ------- > > The old windows-specific code did not parse the rules file located in > applicationDirPath/../share/rules. > > This also reduces the code duplication (by a few lines) and the number of > #ifdef Q_OS_WIN. > > > Diffs > ----- > > soprano/inference/inferenceruleset.cpp 6275c9c > > Diff: http://git.reviewboard.kde.org/r/102468/diff > > > Testing > ------- > > Compilation only. I have no windows. The possible test on linux: move rules > files from soprano install dir to another dir in XDG_DATA_DIRS. I'll can try > it next week-end (too busy until 1st of September). > > > Thanks, > > Yury Georgievich > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
