On Wednesday, September 21, 2011 05:57:38 PM Michael Jansen wrote: > On Wednesday, September 21, 2011 07:39:16 AM Alexander Neundorf wrote: > > On Friday, September 16, 2011 05:16:06 PM Stephen Kelly wrote: > > > Alexander Neundorf wrote: > > > > Hi, > > > > > > > > this file looks quite good. > > > > > > > > Only comments: > > > > > > > > * this part is unnecessary: > > > > if ( BLUEZ_INCLUDE_DIR AND BLUEZ_LIBRARIES ) > > > > > > > > # in cache already > > > > set(BlueZ_FIND_QUIETLY TRUE) > > > > > > > > endif ( BLUEZ_INCLUDE_DIR AND BLUEZ_LIBRARIES ) > > > > > > > > since find_package_handle_standard_args() anyway only prints > > > > something if > > > > this output differs from the previous run > > > > > > > > * the if(NOT WIN32) around the pkgconfig-stuff can be removed, if > > > > pkgconfig is not found, pkg_check_modules() simply does nothing > > Not sure here. After a (short) talk to some kde windows guys i remember he > said there is pkgconfig for windows but it is considered completly broken. > I think thats why most modules do that magic. Do ignore it on windows even > if there.
Windows devs, any comments on this ? Alex _______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
