Hi! I'm under the impression, not too many KDE-Windows folks are following kde- core-devel (I'm doing so rather cursorily and sporadically, myself). So, just in case, I'll forward the review request, below.
Looks good to me on first glance, but I'm really not an expert on the many pitfalls of KUrl. Regards Thomas ---------- Forwarded Message ---------- Subject: Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows Date: Saturday 18 May 2013, 14:36:35 From: Allen Winter <[email protected]> To: Michel Ludwig <[email protected]>, Allen Winter <[email protected]>, kdelibs <[email protected]> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109246/#review32742 ----------------------------------------------------------- any KDE Windows folks feel like taking a look at this one? - Allen Winter On March 2, 2013, 4:54 p.m., Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109246/ > ----------------------------------------------------------- > > (Updated March 2, 2013, 4:54 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Absolute paths can, for example, have the form "E:/MyDocuments/test/test.tex" on Windows. Currently, KUrl::_relativePath assumes that > "E:/MyDocuments/test/test.tex" is a relative path and > > KUrl::relativePath("E:/MyDocuments/", "E:/MyDocuments/test/test.tex") > > will therefore return "E:/MyDocuments/test/test.tex" instead of "test/test.tex". The attached patch fixes this issue. > > > Diffs > ----- > > kdecore/io/kurl.cpp ef2ba12 > > Diff: http://git.reviewboard.kde.org/r/109246/diff/ > > > Testing > ------- > > > Thanks, > > Michel Ludwig > > -----------------------------------------
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
