> On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote:
> > src/backends/python2/CMakeLists.txt, line 15
> > <https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15>
> >
> > Shouldn't this go into the kdewin include files then?
>
> Andrius da Costa Ribas wrote:
> kdewin does this
>
> http://quickgit.kde.org/?p=kdewin.git&a=blob&h=056cd64165e3e5c76d7878c13806551dca7c3182&hb=ae1c0ac291cc97d432b73091bb17b32120038b6c&f=include%2Fmsvc%2Fsys%2Ftypes.h
>
> #ifndef _SSIZE_T_DEFINED
> #define _SSIZE_T_DEFINED
> typedef SSIZE_T ssize_t;
> #endif
>
> the problem is that the python one doesn't.
>
>
> Albert Astals Cid wrote:
> Ah, i see what you mean. Quick question, how does kdewin headers end up
> in cantor?
kdewin's include/msvc include path is part of ${KDE4_INCLUDES}
Python's Python.h includes "limits.h" which is in present in include/msvc
include path, this then which includes "sys/types.h", also from kdewin.
- Andrius da Costa
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/#review47190
-----------------------------------------------------------
On Jan. 11, 2014, 2:37 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114964/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 2:37 p.m.)
>
>
> Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.
>
>
> Repository: cantor
>
>
> Description
> -------
>
> This typedef is in both kdewin's sys/types (msvc/include) and python config
> headers. By adding this definition the typedef present in kdewin is skipped.
>
>
> Diffs
> -----
>
> src/backends/python2/CMakeLists.txt d27d88f
>
> Diff: https://git.reviewboard.kde.org/r/114964/diff/
>
>
> Testing
> -------
>
> Python backend builds and run fine from a clean MSVC build.
> MinGW build was already okay, as per
> http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows
