----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115107/#review48100 -----------------------------------------------------------
Ship it! I'm fine with this -- in any case, i don't build the tests on windows anyway. - Boudewijn Rempt On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115107/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2014, 3:42 a.m.) > > > Review request for Calligra and kdewin. > > > Repository: calligra > > > Description > ------- > > Avoid conflicts on MinGW since these sources refer to headers where the > classes are "dllimport" (since at this point we are not building the library). > > Obs.: This is not the case for the next targets in this CMake file, since > kis_tile_data is not exported. > > > Diffs > ----- > > krita/image/tiles3/tests/CMakeLists.txt 5339543 > > Diff: https://git.reviewboard.kde.org/r/115107/diff/ > > > Testing > ------- > > Builds on both MinGW and MSVC. > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
