> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > <https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170> > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The fix here is that RUNTIME_OUTPUT_DIRECTORY -> > CMAKE_RUNTIME_OUTPUT_DIRECTORY because the first one is a target property and > not a global variable. I also modified the > CMAKE_ARCHIVE|LIBRARY_OUTPUT_DIRECTORY's values, but that isn't strictly > required. > > Patrick von Reth wrote: > yes but you install the dll to ${CMAKE_BINARY_DIR}/lib > > " set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")"
No, the dll is RUNTIME so it goes into /bin. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57180 ----------------------------------------------------------- On May 2, 2014, 10:53 p.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117965/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 10:53 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > kdewin. > > > Repository: extra-cmake-modules > > > Description > ------- > > use the correct global variables > > > Diffs > ----- > > kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 > > Diff: https://git.reviewboard.kde.org/r/117965/diff/ > > > Testing > ------- > > windows > > > Thanks, > > Patrick Spendrin > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
