----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118026/#review57477 -----------------------------------------------------------
Ship it! looks good, I don't remember what weird reason required us to use the current setup. If it becomes a problem, we have to modify it anyway. - Patrick Spendrin On May 6, 2014, 8:29 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118026/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 8:29 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kinit > > > Description > ------- > > Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows > > No longer create an empty dummy library, instead create a static library > with all the sources and link the exectuable to that. > > This fixes the build of Kate on Windows since some unit tests use > target_link_libraries(test kdeinit_kate) and since that library was empty > it would not contain the required symbols > > > Diffs > ----- > > CMakeLists.txt 9e34058ab612732adba50331db624d2c307da0dd > KF5InitMacros.cmake 1768bc96573ca0fabf6bf620e4ff0a3f5f3646a5 > kde5init_win32lib_dummy.cpp.in d727297578834ba2f2c3ee8f086c355244f116de > > Diff: https://git.reviewboard.kde.org/r/118026/diff/ > > > Testing > ------- > > Kate tests link now, didn't before > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
