> On May 13, 2014, 12:44 p.m., Alex Merry wrote: > > autotests/CMakeLists.txt, line 16 > > <https://git.reviewboard.kde.org/r/118111/diff/1/?file=272711#file272711line16> > > > > Doesn't this macro now basically just do what ecm_add_tests does? Why > > not replace the single call to it with an ecm_add_tests call? > > Patrick von Reth wrote: > because this macro uses a loop and we would need to copy the > link_libraries etc for each test > > Alex Merry wrote: > No, I meant ecm_add_tests, rather than ecm_add_test. ecm_add_tests just > does ecm_add_test in a loop.
Since there is only one source file per test ecm_add_tests is fine - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/#review57858 ----------------------------------------------------------- On May 13, 2014, 10:36 a.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118111/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 10:36 a.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kdelibs4support > > > Description > ------- > > adapt to ecm_add_tests > > > Diffs > ----- > > autotests/CMakeLists.txt e9a0421e734de72eff9bc29a7f28201116c240f6 > > Diff: https://git.reviewboard.kde.org/r/118111/diff/ > > > Testing > ------- > > windows, some tests fail but they will need porting > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
