> On Jul. 6, 2014, 4:30 p.m., Patrick von Reth wrote: > > analitzaplot/CMakeLists.txt, line 15 > > <https://git.reviewboard.kde.org/r/119000/diff/1/?file=285137#file285137line15> > > > > Please enable it also for mingw, so WIN32 instead of MSVC.
MinGW needs `_BSD_SOURCE` or `_GNU_SOURCE` instead of `_USE_MATH_DEFINES`. I'll post a new patch. - Nicolás ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119000/#review61747 ----------------------------------------------------------- On Jul. 6, 2014, 4:23 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119000/ > ----------------------------------------------------------- > > (Updated Jul. 6, 2014, 4:23 p.m.) > > > Review request for KDE Edu and kdewin. > > > Repository: analitza > > > Description > ------- > > Add _USE_MATH_DEFINES on MSVC, it's needed to get M_PI. > > See http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx > > > Diffs > ----- > > analitzaplot/CMakeLists.txt 008febe > > Diff: https://git.reviewboard.kde.org/r/119000/diff/ > > > Testing > ------- > > Builds on MSVC2013. > > > Thanks, > > Nicolás Alvarez > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
