----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128779/#review99844 -----------------------------------------------------------
kde-modules/KDECompilerSettings.cmake (line 87) <https://git.reviewboard.kde.org/r/128779/#comment67097> This must be CMAKE_CXX_SIMULATE_ID no? kde-modules/KDECompilerSettings.cmake (line 201) <https://git.reviewboard.kde.org/r/128779/#comment67098> This and below one must be c++11 or even c++1y ? - Anthony Fieroni On Окт. 8, 2016, 9:41 преди обяд, Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128779/ > ----------------------------------------------------------- > > (Updated Окт. 8, 2016, 9:41 преди обяд) > > > Review request for Extra Cmake Modules and kdewin. > > > Repository: extra-cmake-modules > > > Description > ------- > > By simply using `if(CMAKE_COMPILER_ID STREQUAL "Clang")` check is not enough > for clang-cl, as it turns on various '-style' flags and omits MSVC's '/style' > flags. > > With this patch i managed to compile much of KF5 up to konversation and kate. > > Known problems: `-std=gnu++98` flag is still appended, but i wasn't able to > figure out why. > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake dfa29f7 > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/128779/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
