Hi Guys. I've talked to Marco about the include format of the ffmpeg headers and have some questions:
ffmpeg developers say the correct way to include the headers since 0.4.9 is <dir/header.h>; KDE4 from trunk (since June 12th, and soon to be 4.1) uses this way too; So, why are we using the old one method? What I suggest: 1. Copy FindFFmpeg.cmake from KDE's trunk into kdenlive; 2. Change renderer.cpp to #include <libavformat/avformat.h>; 3. Remove these modules, as they are not used anymore or are part of kdelibs: FindGettext.cmake FindKdeLibs.cmake FindLIBFFMPEG.cmake FindMSGFMT.cmake KdenlivePackageMessages.cmake And If we want to depend o at least kde 4.1, we can remove FindFFmpeg.cmake too after that. I'm proposing this because if we start duplicating the modules, we end up like the autotools hell, mantaining every module on our own. What do you think? Ok to do commit the changes? Regards, -- ----------------------------------------------------------------- "Your mind is like a parachute: it works better when open." Lúcio Flávio Corrêa (+55) (87) 9118-8115 lucio.correa #at# gmail.com luciocorrea.wordpress.com topeira -> irc.freenode.net ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Kdenlive-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
