Hi,
I just added support for the LADSPA 1197 effect (15 band equalizer). Here's
the xml file, and the patch making the required changes to CMakeLists and
initeffects.cpp. I also changed the "Equalizer" effect name to "3 band
equalizer".
Could someone check this is ok and commit if it is so ? Thanks.
The code changes required for Ladspa effects are a bit cumbersome, and there
seems to be a leasr one unused fonction (ladspaEffectString()). I'll see of
I can do a quick cleanup around there and send a patch...
Cheers,
Hugh
Index: effects/ladspa_equalizer.xml
===================================================================
--- effects/ladspa_equalizer.xml (revision 5015)
+++ effects/ladspa_equalizer.xml (working copy)
@@ -3,13 +3,13 @@
<name>3 Band Equalizer</name>
<description>LADSPA equalizer audio effect</description>
<author>http://www.ladspa.org</author>
- <parameter type="constant" name="logain" max="6" min="-70" default="0">
+ <parameter type="constant" name="logain" max="12" min="-70" default="0">
<name>Lo gain</name>
</parameter>
- <parameter type="constant" name="midgain" max="6" min="-70" default="0">
+ <parameter type="constant" name="midgain" max="12" min="-70" default="0">
<name>Mid gain</name>
</parameter>
- <parameter type="constant" name="higain" max="6" min="-70" default="0">
+ <parameter type="constant" name="higain" max="12" min="-70" default="0">
<name>Hi gain</name>
</parameter>
</effect>
\ No newline at end of file
Index: effects/CMakeLists.txt
===================================================================
--- effects/CMakeLists.txt (revision 5015)
+++ effects/CMakeLists.txt (working copy)
@@ -14,6 +14,7 @@
invert.xml
ladspa_declipper.xml
ladspa_equalizer.xml
+ladspa_equalizer_15.xml
ladspa_limiter.xml
ladspa_phaser.xml
ladspa_pitch_scale.xml
Index: src/initeffects.h
===================================================================
--- src/initeffects.h (revision 5015)
+++ src/initeffects.h (working copy)
@@ -117,6 +118,7 @@
static const char* ladspaPitchShifterEffectString(QStringList params);
static const char* ladspaPhaserEffectString(QStringList params);
static const char* ladspaRateScalerEffectString(QStringList params);
+ static const char* ladspaEqualizer15EffectString(QStringList params);
private:
initEffects(); // disable the constructor
Index: src/initeffects.cpp
===================================================================
--- src/initeffects.cpp (revision 5015)
+++ src/initeffects.cpp (working copy)
@@ -479,6 +483,9 @@
case 1217: // Phaser
filterString = ladspaPhaserEffectString(params);
break;
+ case 1197: // 15 Band Equalizer
+ filterString = ladspaEqualizer15EffectString(params);
+ break;
default:
kDebug() << "++++++++++ ASKING FOR UNKNOWN LADSPA EFFECT: " << ladspaId << endl;
return;
@@ -552,6 +559,10 @@
{
return qstrdup(QString(jackString + "1217</id><enabled>true</enabled><wet_dry_enabled>false</wet_dry_enabled><wet_dry_locked>true</wet_dry_locked><wet_dry_values><value>1.000000</value><value>1.000000</value></wet_dry_values><lockall>true</lockall><controlrow><lock>true</lock><value>%1</value><value>%1</value></controlrow><controlrow><lock>true</lock><value>%2</value><value>%2</value></controlrow><controlrow><lock>true</lock><value>%3</value><value>%3</value></controlrow><controlrow><lock>true</lock><value>%4</value><value>%4</value></controlrow></plugin></jackrack>").arg(params[0]).arg(params[1]).arg(params[2]).arg(params[3]).toUtf8());
}
+const char* initEffects::ladspaEqualizer15EffectString(QStringList params)
+{
+ return qstrdup(QString(jackString + "1197</id><enabled>true</enabled> <wet_dry_enabled>false</wet_dry_enabled><wet_dry_locked>true</wet_dry_locked> <wet_dry_values><value>1.000000</value><value>1.000000</value></wet_dry_values> <controlrow><value>%1</value></controlrow> <controlrow><value>%2</value></controlrow> <controlrow><value>%3</value></controlrow> <controlrow><value>%4</value></controlrow> <controlrow><value>%5</value></controlrow> <controlrow><value>%6</value></controlrow> <controlrow><value>%7</value></controlrow> <controlrow><value>%8</value></controlrow> <controlrow><value>%9</value></controlrow> <controlrow><value>%10</value></controlrow> <controlrow><value>%11</value></controlrow> <controlrow><value>%12</value></controlrow> <controlrow><value>%13</value></controlrow> <controlrow><value>%14</value></controlrow> <controlrow><value>%15</value></controlrow> </plugin></jackrack>").arg(params[0]).arg(params[1]).arg(params[2]).arg(params[3]).arg(params[4]).arg(params[5]).arg(params[6]).arg(params[7]).arg(params[8]).arg(params[9]).arg(params[10]).arg(params[11]).arg(params[12]).arg(params[13]).arg(params[14]).toUtf8());
+}
QDomDocument initEffects::createDescriptionFromMlt(Mlt::Repository* repository, const QString& /*type*/, const QString& filtername)
<!DOCTYPE kpartgui>
<effect tag="ladspa" library="mbeq_1197.so" id="equalizer_15" ladspaid="1197" type="audio">
<name>15 Band Equalizer</name>
<description>LADSPA equalizer audio effect (15 band)</description>
<author>http://www.ladspa.org</author>
<parameter type="constant" name="1" max="12" min="-70" default="0">
<name>1</name>
</parameter>
<parameter type="constant" name="2" max="12" min="-70" default="0">
<name>2</name>
</parameter>
<parameter type="constant" name="3" max="12" min="-70" default="0">
<name>3</name>
</parameter>
<parameter type="constant" name="4" max="12" min="-70" default="0">
<name>4</name>
</parameter>
<parameter type="constant" name="5" max="12" min="-70" default="0">
<name>5</name>
</parameter>
<parameter type="constant" name="6" max="12" min="-70" default="0">
<name>6</name>
</parameter>
<parameter type="constant" name="7" max="12" min="-70" default="0">
<name>7</name>
</parameter>
<parameter type="constant" name="8" max="12" min="-70" default="0">
<name>8</name>
</parameter>
<parameter type="constant" name="9" max="12" min="-70" default="0">
<name>9</name>
</parameter>
<parameter type="constant" name="10" max="12" min="-70" default="0">
<name>10</name>
</parameter>
<parameter type="constant" name="11" max="12" min="-70" default="0">
<name>11</name>
</parameter>
<parameter type="constant" name="12" max="12" min="-70" default="0">
<name>12</name>
</parameter>
<parameter type="constant" name="13" max="12" min="-70" default="0">
<name>13</name>
</parameter>
<parameter type="constant" name="14" max="12" min="-70" default="0">
<name>14</name>
</parameter>
<parameter type="constant" name="15" max="12" min="-70" default="0">
<name>15</name>
</parameter>
</effect>------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Kdenlive-devel mailing list
Kdenlive-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
