KDE static analysis tool has some complains about kdenlive: http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/kdenlive/index.html
This patch set tries to fix most of these complaints: krazy2 Analysis Checkers Run = 54 Files Processed = 500 Total Issues = 973 ...as of June 28 2012 04:31:57 UTC For File Type cmake Check that file ends with a newline [endswithnewline]...OOPS! 1 issues found! cmake/modules/FindLibV4L2.cmake: line# 26 (1) Files that do not end with a newline character can cause problems. Please add a newline character to the end of the file. Check for spelling errors [spelling]...okay! For File Type c++ Check for TRUE and FALSE macros [captruefalse]...OOPS! 4 issues found! src/onmonitoritems/rotoscoping/graphicsgems.h: using TRUE line# 133,134 (2) src/onmonitoritems/rotoscoping/graphicsgems.h: using FALSE line# 137,138 (2) The TRUE and FALSE macros are obsolete and should be replaced with true and false (all lower case) respectively. Check for methods that return 'const' refs in public classes [constref]...okay! Check for an acceptable copyright [copyright]...OOPS! 13 issues found! src/onmonitoritems/rotoscoping/nearestpoint.cpp: missing tags line# 21 (1) src/jogshuttleconfig.h: missing tags line# 3 (1) src/lib/external/kiss_fft/kiss_fft.h: missing tags src/lib/external/kiss_fft/kiss_fft.c: missing tags line# 2 (1) src/lib/external/kiss_fft/_kiss_fft_guts.h: missing tags line# 2 (1) src/lib/external/kiss_fft/tools/kiss_fastfir.c: missing tags line# 2 (1) src/lib/external/kiss_fft/tools/kiss_fftnd.c: missing tags line# 4 (1) src/lib/external/kiss_fft/tools/psdpng.c: missing tags line# 2 (1) src/lib/external/kiss_fft/tools/kfc.c: missing tags line# 4 (1) src/lib/external/kiss_fft/tools/fftutil.c: missing tags line# 2 (1) src/lib/external/kiss_fft/tools/kfc.h: missing tags src/lib/external/kiss_fft/tools/kiss_fftndr.c: missing tags line# 2 (1) src/lib/external/kiss_fft/tools/kiss_fftr.c: missing tags line# 2 (1) All source files must contain a copyright header which identifies the copyright holder(s) together with a e-mail address that can be used to reach the copyright holder. One copyright holder per line, with real email addresses please. For details regarding KDE's licensing policy please visit http://techbase.kde.org/Policies/Licensing_Policy. A typical copyright looks like: "Copyright 2002,2005-2006 Joe Hacker " Check for cpp macros and usage [cpp]...okay! Check for code that should be considered crashy. [crashy]...OOPS! 41 issues found! plugins/sampleplugin/sampleplugin.cpp: line# 71 (1) src/recmonitor.cpp: line# 888 (1) src/titlewidget.cpp: line# 1855 (1) src/kdenlivesettingsdialog.cpp: line# 484,495,506,992,1080 (5) src/customtrackview.cpp: line# 1360,3084,3181,5253,5284,5296,5921,5953,5966 (9) src/effectstack/collapsibleeffect.cpp: line# 161 (1) src/mainwindow.cpp: line# 1834,1873,2061,2219,2243,2305,2830,2914,3268,3323,3747,3837,4459 (13) src/monitor.cpp: line# 585 (1) src/projectlist.cpp: line# 1648,1822,1895,2737,3327,3388 (6) src/clipproperties.cpp: line# 722,734 (2) src/kdenlivedoc.cpp: line# 1270 (1) Looks for not using QPointers when showing modal dialogs via exec(), as discussed in http://www.kdedevelopers.org/node/3919 Tested briefly with latest kdenlive with and without these patches and mlt and ffmpeg from git on Debian unstable. Had some weird problems on Debian unstable (odd kdenlive crashes etc) but they seem to be gone with latest apt-get upgrade. Saw one odd looking crash during testing but missed the trace and was not able to reproduce it under gdb. Please review and even test a bit more before applying, thanks. Mikko Rapeli (37): FindLibV4L2.cmake: Add new line to end of file Remove obsolete TRUE and FALSE definitions Fix copyrights Add copyright and license Create dialog on heap instead of stack Use QPointer Use QPointer settingsdialog: Use QPointer editItemDuration: Use QPointer slotRemoveSpace: Use QPointer slotInsertSpace: Use QPointer slotAddGuide: Use QPointer slotEditGuide: Use QPointer slotEditTimeLineGuide: Use QPointer slotInsertTrack: Use QPointer slotDeleteTrack: Use QPointer slotConfigTracks: Use QPointer collapsibleeffect.cpp: Use QPointer readOptions: Use QPointer slotRunWizard: Use QPointer newFile: Use QPointer openFile: Use QPointer parseProfiles: Use QPointer, delete on error path slotEditProjectSettings: Use QPointer slotAddClipMarker: Use QPointer slotEditClipMarker: Use QPointer slotShowClipProperties: Use QPointer slotShowClipProperties: Use QPointer getNewStuff: Use QPointer slotDvdWizard: Use QPointer slotOpenBackupDialog: Use QPointer slotExtractCurrentFrame: Use QPointer projectlist.cpp: Use QPointer clipproperties.cpp: Use QPointer kdenlivedoc.cpp: Use QPointer Compare with isEmpty() instead of null string "" End files with new line cmake/modules/FindLibV4L2.cmake | 3 +- plugins/sampleplugin/sampleplugin.cpp | 13 ++- src/clipproperties.cpp | 8 +- src/clipstabilize.cpp | 2 +- src/customtrackview.cpp | 134 ++++++++++++++----------- src/effectstack/collapsibleeffect.cpp | 2 +- src/jogaction.cpp | 2 +- src/jogshuttleconfig.cpp | 2 +- src/jogshuttleconfig.h | 3 +- src/kdenlivedoc.cpp | 2 +- src/kdenlivesettingsdialog.cpp | 35 ++++--- src/lib/external/kiss_fft/kiss_fft.h | 14 +++ src/lib/external/kiss_fft/tools/kfc.h | 15 +++ src/mainwindow.cpp | 69 ++++++++----- src/monitor.cpp | 2 +- src/onmonitoritems/rotoscoping/graphicsgems.h | 8 -- src/projectlist.cpp | 10 +- src/projecttree/meltjob.cpp | 3 +- src/recmonitor.cpp | 2 +- src/titlewidget.cpp | 4 +- src/unicodedialog.cpp | 2 +- src/utils/resourcewidget.cpp | 3 +- 22 files changed, 207 insertions(+), 131 deletions(-) -- 1.7.10.4 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Kdenlive-devel mailing list Kdenlive-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
