Hi all,
I'm a small time user of kdenlive. I have used it to do few reports of
miniature wargames. I have done 6 different videos at the moment. You
can find them from youtube (user henafoo) if interested.
For my coding background I use perl and bash and a bit of python in my
day job (bioinformatician). I have done work with c for emboss (a longer
time back), which is a sequence analysis package
(http://emboss.sourceforge.org). Also I have dabbled a bit with java.
I'm currently reading through a c++ book 'C++ Annotations' and was
interested in getting some real world understanding. Thus this lead me
to get kdenlive code and check out some bug reports. So I'm quite a
beginner with c++ as well as kdenlive code.
This all said, I saw a bug 3197 and decided to try to apply myself for
this, since the bug is so well described.
http://www.kdenlive.org/mantis/view.php?id=3197
The patch I created is attached, it is against the git master. It seems
to work as after this it does not crash and saves the screen grab (with
or without offsets). I don't have firewire possibility for testing.
I might have up to hour or two per week to do very simple bug hunting.
Is there a preferred way of submitting patches? I would certainly be
happy to learn more c++ so comments on this and/or hopefully future
patches are more than welcome.
Thanks,
--
Henrikki Almusa
diff --git a/src/recmonitor.cpp b/src/recmonitor.cpp
index e104426..8422084 100644
--- a/src/recmonitor.cpp
+++ b/src/recmonitor.cpp
@@ -723,14 +723,14 @@ void RecMonitor::slotRecord()
m_captureArgs << "-f" << "x11grab";
if (KdenliveSettings::grab_follow_mouse()) m_captureArgs << "-follow_mouse" << "centered";
if (!KdenliveSettings::grab_hide_frame()) m_captureArgs << "-show_region" << "1";
+ captureSize = ":0.0";
if (KdenliveSettings::grab_capture_type() == 0) {
// Full screen capture
- captureSize = ":0.0";
m_captureArgs << "-s" << QString::number(screenSize.width()) + "x" + QString::number(screenSize.height());
} else {
// Region capture
m_captureArgs << "-s" << QString::number(KdenliveSettings::grab_width()) + "x" + QString::number(KdenliveSettings::grab_height());
- captureSize = ":" + QString::number(KdenliveSettings::grab_offsetx()) + "." + QString::number(KdenliveSettings::grab_offsetx());
+ captureSize.append("+" + QString::number(KdenliveSettings::grab_offsetx()) + "." + QString::number(KdenliveSettings::grab_offsetx()));
}
// fps
m_captureArgs << "-r" << QString::number(KdenliveSettings::grab_fps());
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Kdenlive-devel mailing list
Kdenlive-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
