2009/11/2 Jean-Michel Pour? <jm at poure.com>: > On Mon, 2009-11-02 at 18:27 -0800, Dan Dennedy wrote: >> >> Oh, wait, that was not me. That was jmp, but that change will break my >> previous change that should intelligently allow either libfaac or aac. >> What I mean is that >> >> http://kdenlive.svn.sourceforge.net/viewvc/kdenlive/trunk/kdenlive/export/profiles.xml?view=log#rev4072 >> >> seems to break my previous change to deal with this: >> >> http://kdenlive.svn.sourceforge.net/viewvc/kdenlive/trunk/kdenlive/src/renderwidget.cpp?view=log&pathrev=3896 >> >> However, this bug report shows my change may not have been working >> correctly or everywhere: >> >> http://www.kdenlive.org/mantis/view.php?id=1223 > > Please take control of this issue and fix in your opinion. > I am starting to feel that we should be like FFmpeg and coerce people away from libfaac. Within the next release or two I feel it is reasonable to expect a version of FFmpeg from within the past 6 months. Even if they do not, we have a bug in our database that libfaac should be avoided due its poor quality and use libmp3lame except where AAC is required for compatibility reasons (e.g. some media player hardware), and I kind of agree. So, I think I will just remove my code since it now just cruft.
-- +-DRD-+
