OK for me, minor change that shouldn't break anything... and adds value, which we should expose in GUI!
Le 01/06/2015 16:30, Dan Dennedy a écrit : > Please review and let me know if you approve this. > > ---------- Forwarded message --------- > From: Orhan Kavrakoğlu <[email protected] > <mailto:[email protected]>> > Date: Mon, Jun 1, 2015 at 4:55 AM > Subject: [mlt] Add a preferred-width attribute to kdenlivetitle text > content properties (#78) > To: mltframework/mlt <[email protected] > <mailto:[email protected]>> > > > Would you be interested in such a solution for centered text? It's a > requested feature: > > https://kdenlive.org/forum/title-template-aligning-doesnt-work > https://kdenlive.org/forum/center-align-template-title > https://kdenlive.org/forum/template-documentation > > The current implementation sets the preferred width to be the text > item's actual width (src/modules/qt/kdenlivetitle_wrapper.cpp:229), > making center- and right-alignment meaningless unless the text is > multiline. (When it /is/ multiline, it merely aligns shorter lines > according to the longest one) > > With this change, you can set preferred-width="x" and it will act as > though the text item had that width. Set x to the video's width and > you can have perfectly centered (or right-aligned) titles. > > ------------------------------------------------------------------------ > > > You can view, comment on, or merge this pull request online at: > > https://github.com/mltframework/mlt/pull/78 > > > Commit Summary > > * Add a preferred-width attribute to kdenlivetitle text content > properties so we can actually center text > > > File Changes > > * *M* src/modules/qt/kdenlivetitle_wrapper.cpp > <https://github.com/mltframework/mlt/pull/78/files#diff-0> (4) > > > Patch Links: > > * https://github.com/mltframework/mlt/pull/78.patch > * https://github.com/mltframework/mlt/pull/78.diff > > — > Reply to this email directly or view it on GitHub > <https://github.com/mltframework/mlt/pull/78>. > > > > _______________________________________________ > kdenlive mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kdenlive
_______________________________________________ kdenlive mailing list [email protected] https://mail.kde.org/mailman/listinfo/kdenlive
