----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129011/#review99505 -----------------------------------------------------------
src/bin/bin.cpp (line 2569) <https://git.reviewboard.kde.org/r/129011/#comment66935> Very nice job, thanks a lot for that. Just a detail, it is recommanded to use QLatin1String() in these string comparisons, like: mltServie == QLatin1String("avformat-novalidate") ... - Jean-Baptiste Mardelle On Sept. 24, 2016, 5:45 p.m., The DiveO wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129011/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2016, 5:45 p.m.) > > > Review request for Kdenlive. > > > Repository: kdenlive > > > Description > ------- > > This patch gives a little love to Kdenlive's library: > - replaces the ambigious "+" icon to add a library clip to your project with > the "add clip" icon, thus getting in line of adding a clip to the project bin. > - improves on error reporting during playlist expansion: errors are now > clearly reported to the user through the status bar reporting mechanism; most > users won't have a terminal window visible while using Kdenlive, so they > won't see the error debug messages. > - fixes Kdenlive hanging for a very loooooooong time while trying to load > producers after playlist expansion due to relative paths failing. This patch > checks for relative producer urls during expansion and properly re-roots them > based on the playlist's root element/directory. Of course, this does not fix > issues where clips have been moved after a library playlist clip has been > created. > > > Diffs > ----- > > src/bin/bin.cpp 00d9587 > src/library/librarywidget.cpp 7620bbe > src/mainwindow.cpp 8022226 > src/timeline/customtrackview.cpp 3462496 > > Diff: https://git.reviewboard.kde.org/r/129011/diff/ > > > Testing > ------- > > Tested on recent Kdenlive git master. > > > Thanks, > > The DiveO > >
