----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129218/#review100125 -----------------------------------------------------------
src/effectslist/initeffects.cpp (line 565) <https://git.reviewboard.kde.org/r/129218/#comment67253> please check that the effect name is not empty before attempting to uppercase - Jean-Baptiste Mardelle On Oct. 18, 2016, 11:43 p.m., alcinos alcinos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129218/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 11:43 p.m.) > > > Review request for Kdenlive. > > > Repository: kdenlive > > > Description > ------- > > Force Capitalization of first letter in effects name and rename some effects > to make them less cryptic. > > > Diffs > ----- > > data/effects/frei0r_mask0mate.xml 885f01e > data/effects/frei0r_pr0be.xml 6bd6e97 > data/effects/frei0r_pr0file.xml 94adb4a > data/effects/frei0r_threelay0r.xml cf04951 > data/effects/frei0r_threshold0r.xml bb2244b > data/effects/frei0r_twolay0r.xml fa1075f > data/effects/threshold.xml 6a38fee > src/effectslist/initeffects.cpp e6dd1c7 > > Diff: https://git.reviewboard.kde.org/r/129218/diff/ > > > Testing > ------- > > Works ok on latest master > > > Thanks, > > alcinos alcinos > >