----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129270/ -----------------------------------------------------------
(Updated Nov. 4, 2016, 11:53 a.m.) Review request for Kdenlive. Changes ------- Improve design of ColorPicker and add base-class The deprecated displayMessage mechanism from parameterContainer has been removed. Repository: kdenlive Description ------- This is a first step towards a refactoring of the effects stack. Currently the different widgets do not share a base class and their creation based on the xml is a bit cluttered, with a lot of redundancies. The plan is to unify this by creating a proper factory method. I'll split the work into small and hopefully easy to review bits so that we make sure that no feature is lost on the way. Diffs (updated) ----- src/CMakeLists.txt 2814fa3 src/bin/generators/generators.cpp 03f1479 src/effectstack/CMakeLists.txt 80ae0d6 src/effectstack/collapsiblegroup.h d0c0f00 src/effectstack/effectstackedit.h 4d51f9b src/effectstack/geometryval.h 82d7e71 src/effectstack/geometryval.cpp 3e0436c src/effectstack/keyframeedit.h f63f697 src/effectstack/keyframeedit.cpp 5739ea0 src/effectstack/parametercontainer.h 3b1b1b3 src/effectstack/parametercontainer.cpp ccec798 src/effectstack/widgets/abstractparamwidget.h PRE-CREATION src/effectstack/widgets/animationwidget.h 4e13503 src/effectstack/widgets/animationwidget.cpp cc86e26 src/effectstack/widgets/boolparamwidget.h PRE-CREATION src/effectstack/widgets/boolparamwidget.cpp PRE-CREATION src/effectstack/widgets/choosecolorwidget.h 736bdf7 src/effectstack/widgets/choosecolorwidget.cpp 546d0be src/effectstack/widgets/colorpickerwidget.h edee5e2 src/effectstack/widgets/colorpickerwidget.cpp f567c20 src/effectstack/widgets/cornerswidget.h 221bb3d src/effectstack/widgets/doubleparameterwidget.h 7c81a2e src/effectstack/widgets/doubleparameterwidget.cpp bf7f245 src/effectstack/widgets/draggablelabel.h PRE-CREATION src/effectstack/widgets/draggablelabel.cpp PRE-CREATION src/effectstack/widgets/geometrywidget.h 681e5cb src/effectstack/widgets/geometrywidget.cpp 9201e3b src/effectstack/widgets/listparamwidget.h PRE-CREATION src/effectstack/widgets/listparamwidget.cpp PRE-CREATION src/mltcontroller/clippropertiescontroller.cpp 1e0a340 src/ui/boolval_ui.ui 5f22525 src/ui/geometryval_ui.ui 1705840 src/ui/listval_ui.ui 7bc1925 Diff: https://git.reviewboard.kde.org/r/129270/diff/ Testing ------- Tested with a mock project Thanks, alcinos alcinos