I have not yet heard from Santanu on the changes to Strut's ModelAction, but I have figured out a piece of his intent. Currently, the Strut's client drops all files that are uploaded to it. Uploaded files are NOT available for Models to work with.
This is a priority project for me, and something I must absolutely have. And the fact that the Struts Client WON'T handle file uploads, but insteads drops them, is something severe enough to be considered a bug. I am perfectly willing to take over this, and I have a short deadline as well (already overran it, to tell you the truth). So getting Strut's ModelAction to the point where it can handle fileuploads is something that will be done before the 2.0 release (unless 2.0 is released in the next week or so????)
There are some other additions that were made to the Strut's ModelAction v1.0 that I would like to know the whys about as well, specificially the generation of two hidden fields, COMMAND & PARAMS. I don't think they are necessary with the enhancements for 2.0, but I want to be sure. Santanu? Philip?
Regards, Steve
Sasvata (Shash) Chatterjee wrote:
Steve,
You are probably right, some changes are required on the client side. But ModelAction, as refactored in 2.0, is not the right place to do it. In any case, what you had was the current execute() method, unchanged, and an additional execute_1_0 (or something similar) that wasn't being called. If the changes need to be made, they need to be sprinkled case-by-case into StrutsClientConnector, AbstractWebappClientConnector, AbstractClientConnector, etc.
As I said before, a merge isn't likely to help in this case. Need to identify the changes between the released 1.0 (2.0 was branched from there) ModelAction and the latest version in Branch_1_0. Then, make similar changes to the above classes. I doubt ModelAction will change at all for this.
As far as the 2.0 branch, we have ways yet to go. It is premature to make the branch. But it is getting close to the release to warrant not taking risks with the code. Maybe you can get the changes working and tested on your local machine first? If need be, we can temporarily branch clnt-struts for you to do the final collaboration with Santanu, and when everything works we can merge back to HEAD?
Shash
-- Java/J2EE Developer/Integrator Co-Chair, Dallas/FortWorth J2EE Sig 214-724-7741
http://keelframework.org/documentation Keelgroup mailing list [EMAIL PROTECTED] http://lists.keelframework.com/listinfo.cgi/keelgroup-keelframework.com
