There are quite a few places where cleanUp() is called right before a return inside a try catch block, but also called in the finally() clause of the same try/catch. I've cleaned those out, and it seems to run fine (without any pool problems).
I'm checking in, but if you see problems we can back it out. It runs fine, and the WARN logs are gone.. But I'm not sure I can create enough load on the pool to simulate running out of connections, so I really can't be sure. Maybe you can do an inspection of the code after I check it in and see if it looks OK.
Shash
Michael Nash JGlobal.com wrote:
Shash:
I was noticing this as well, but hand't had the minute to dig into it. You're right, we're probably re-releasing something that was already let go.
Mike
On Mon, 06 Oct 2003 15:19:24 -0500 "Sasvata (Shash) Chatterjee" <[EMAIL PROTECTED]> wrote:
All,
I see this error (at bottom of email) a lot in keelserver.log. it seems like DefaultPersistent.find() calls cleanUp() to clean all the JBDC artifacts up (ResultSet, Connection, etc.). But it seems like it calls it in a "finally" clause as well as throughout the code...is that a problem?
The ArrayIndexOutOfBoundsException in the pool happens because we are returning an object back into the pool, which the pool did not have in its array of "in-use" objects, which, I am guessing, means it has been returned to the pool before?
Is anybody else seeing this (happens on the default deployment, just look at app-poll data or call CRUD functions)? Any ideas? It maybe harmless, but just wondering if we have some issue with connection pool handling.
Shash
WARN 2003-10-06 15:13:05.005 [keel-dbpool] (/org.apache.avalon.excalibur.pool.DefaultPool.put(DefaultPool.java:258)
): Pool interrupted while waiting for lock.
java.lang.ArrayIndexOutOfBoundsException: -1
at java.util.ArrayList.remove(ArrayList.java:395)
at org.apache.avalon.excalibur.pool.DefaultPool.put(DefaultPool.java:225)
at org.apache.avalon.excalibur.datasource.JdbcConnectionPool.put(JdbcConnectionPool.java:232)
at org.apache.avalon.excalibur.datasource.AbstractJdbcConnection.close(AbstractJdbcConnection.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.avalon.excalibur.datasource.AbstractJdbcConnection.invoke(AbstractJdbcConnection.java:357)
at $Proxy10.close(Unknown Source)
at org.keel.services.persist.defaultpersist.DefaultPersistent.cleanUp(DefaultPersistent.java:7967)
at org.keel.services.persist.defaultpersist.DefaultPersistent.find(DefaultPersistent.java:2485)
at org.keel.apps.poll.helpers.CategoryHelper.allowedAdd(CategoryHelper.java:88)
at org.keel.apps.poll.models.ListCategories.execute(ListCategories.java:88)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.avalon.fortress.impl.factory.PassThroughInvocationHandler.invoke(PassThroughInvocationHandler.java:100)
at $Proxy6.execute(Unknown Source)
at org.keel.services.model.defaultmodel.DefaultModelRequest.execute(DefaultModelRequest.java:150)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.avalon.fortress.impl.factory.PassThroughInvocationHandler.invoke(PassThroughInvocationHandler.java:100)
at $Proxy1.execute(Unknown Source)
at org.keel.servers.KeelServerThread.run(KeelServerThread.java:34)
http://keelframework.org/documentation
Keelgroup mailing list
[EMAIL PROTECTED]
http://lists.keelframework.com/listinfo.cgi/keelgroup-keelframework.com
Michael Nash
JGlobal Ltd. http://www.jglobal.com
Bahamas Commerce and Trade
http://www.bahamascommerce.com
http://keelframework.org/documentation Keelgroup mailing list [EMAIL PROTECTED] http://lists.keelframework.com/listinfo.cgi/keelgroup-keelframework.com
