You would only leave it to GC if you didn't close it explicitly yourself. :-) It is trivial to patch Xavante to close its sockets when it is done with them, for example. This way we fully decouple coroutines from sockets, and you can have a coroutine dealing with multiple sockets without issue. Any coroutine that only deals with one socket and was taking benefit from Copas' closing of its socket can be trivially modified to close the socket iself, IMHO.
-- Fabio Mascarenhas On Fri, Dec 18, 2009 at 6:42 PM, Javier Guerra <jav...@guerrag.com> wrote: > On Fri, Dec 18, 2009 at 3:34 PM, Fabio Mascarenhas <mascaren...@acm.org> > wrote: >> Well, I am fine about removing auto-close on the copas HEAD, the >> impact on Xavante should be minimal. Anyone else that uses Copas wants >> to chime in? > > my few uses of it don't track current versions; but i don't think it's > a good idea to leave socket closing to GC. maybe it's better to add a > config option? it's not on the main service loop, so checking if the > copas user wants to close or not shouldn't impact performance > > -- > Javier > > _______________________________________________ > Kepler-Project mailing list > Kepler-Project@lists.luaforge.net > http://lists.luaforge.net/cgi-bin/mailman/listinfo/kepler-project > http://www.keplerproject.org/ > _______________________________________________ Kepler-Project mailing list Kepler-Project@lists.luaforge.net http://lists.luaforge.net/cgi-bin/mailman/listinfo/kepler-project http://www.keplerproject.org/
