On Tue, 2008-09-23 at 17:39 +0200, Mark Phalan wrote: > On Fri, 2008-09-19 at 10:26 -0400, Peter Shoults wrote: > > Mark Phalan wrote: > > > I've just uploaded a webrev of my resync/pkinit workspace. There still > > > needs to be some work on pkinit so don't expect the code in > > > usr/src/lib/krb5/plugins/preauth/pkinit/ to be complete (you can ignore > > > it for now). I'll post another incremental webrev with any changes I > > > make to the pkinit code later on. The rest of the changes are resync > > > changes for MIT 1.6.3. The hg comment needs to be updated, I'll do that > > > once we get the pkinit PSARC case submitted. > > > > > > I've chunked the review up into four pieces as I expect the krb team to > > > do the review. > > > > > > Shawn: Chunk 1 > > > Peter: Chunk 2 > > > Glenn: Chunk 3 > > > Will: Chunk 4 > > > > > > I'd like to have this completed by 17th Sept. Let me know if thats a > > > problem for anyone. > > > > > > webrev here: > > > http://cr.opensolaris.org/~mbp/pkinit/ > > > > > > Cheers, > > > > > > -Mark > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > kerberos-discuss mailing list > > > kerberos-discuss at opensolaris.org > > > http://mail.opensolaris.org/mailman/listinfo/kerberos-discuss > > > > > > > Couple days late, but finally got thru my chunk. Here are my comments: > > ... > > > > -------------- > > > > usr/src/lib/gss_mechs/mech_krb5/krb5/krb/preauth.c > > > > I did not review this file as I assume it is a direct > > copy of MIT stuff....did you want me to review this logic? > > > > Yup :) >
I talked to Pete offlist and he said he's pretty swamped at the moment. Any volunteers to review this file? Shawn: As you're the only one who's actually finished their code review you might be in the best position to take it? Cheers, -M
