On Fri, 2008-04-04 at 01:49 -0600, Shawn M Emery wrote: > Mark Phalan wrote: ... > >> BTW, uses identical code as get master, but > >> that can be handled in a separate bug. > >> > > > > Have you filed it or should I? > > > Please, go ahead.
Ok. ... > >> > kclient.sh: > >> > 46,47,57,193,821,1009,1010,1023,1044,1105,1114,1174,1240,1311,1312 > >> > Message should to to stderr > >> > > >> This fix is doesn't change this behavior, a separate bug should be filed > >> instead. > >> > > > > Want me to file it? > > > Please, go ahead. Ok. ... > > General note: > > I'm really wondering though if this will work properly in a non English > > locale. The translations will have to be very consistent. > > > I'm not a i18n (procedure) expert, do you know some one that could > verify this? I can ask the globalization team here if they can take a look but I doubt that they'll have the time to take a look :( ... > >> Hmm, not relevant to these changes and this check is still valid as the > >> user that belongs to the "Kerberos Client Management" protocol is given > >> an effective uid of 0. > >> > > > > Ok, I guess I can open a low priority bug on this. > > > Yes, low priority, given the fact that the regex will match either uid > or euid (which the associated profile specifies). Ok. > >> > profiles/auths/privs he needs to run the script. > >> > kclient.sh: 1700 > >> > 'svcadm enable' should be run with '-s' and have its return code > >> > checked. > >> > > >> Done. > >> > > > > Everything else looks fine. > > > Thanks for the review. I also simplified > usr/src/lib/krb5/kadm5/clnt/client_init.c, see: > > http://cr.opensolaris.org/~semery/6287615.2 Changes look good. -Mark
