On Fri, 2008-04-04 at 17:21 -0700, Glenn Barry wrote: > Mark Phalan wrote: > > Hi Glenn, > > > > Changes since you last looked at it: > > > > * Incorporated feedback from your review (see mail sent Tue 4th March > > for more details about what changed). > > * Fixed Willf's suggested CR: 6245750 > > - usr/src/cmd/krb5/kadmin/cli/keytab.c > > - usr/src/cmd/krb5/kadmin/server/server_stubs.c > > - usr/src/lib/gss_mechs/mech_krb5/crypto/enctype_to_string.c > > > > * why not use strlcpy instead? > > (i guess its not in the style of the rest of the module but > prolly worth using it anyways going forward)
In this case the buffer size is checked before the copy. However you're right that strlcpy() is generally more desireable. Changed to use strlcpy(). > > > > - usr/src/lib/gss_mechs/mech_krb5/crypto/make_random_key.c > > - usr/src/uts/common/gssapi/mechs/krb5/include/krb5.h > > * Modified acl checking as per Shawn's comments > > - usr/src/cmd/krb5/kadmin/server/ovsec_kadmd.c > > > > ln 944-971 > > * snprintf, fprintf, gss_release_name need (void) return cast Done. > > > 969 + free(gssbuf.value); > > * just in case set this to NULL after free. Done. > > > 948 + snprintf(gssbuf.value, > gssbuf.length,"joe/ad...@%s", > > * need spc ',"joe' Done. > > > > * Modified BFU to remove the unused files > > - usr/src/tools/scripts/bfu.sh > > > > just listing those svcs will make them be removed? Yup. See smf_delete_methods(). > > thats all i gots...thx for all these fixes...gb Thanks for the review. -M
