There is a pretty good discussion in Hadoop community for our reference, and we could see that the answer might not be simple. http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201505.mbox/%[email protected]%3E
Regards, Kai -----Original Message----- From: Emmanuel Lécharny [mailto:[email protected]] Sent: Sunday, July 05, 2015 3:42 PM To: [email protected] Subject: Re: Kerby coding style Le 05/07/15 01:36, Zheng, Kai a écrit : > Hi Stefan, > > Thanks for the hard work and sorting this great list out!! > I'm OK with your preferred options, because most time they're also mine. I'm > surprised we have so many exceptions! Just one thing, LineLength. I'm OK to > use 120 for the check, but I would suggest we should try to avoid so long > lines. Yes, we should never exceed the 120 limit, and if you do, it will fail > the building; meanwhile, 80 is encouraged to make it consistent with most of > existing codes. 80 chars line length limit is there for historical reasons : VT 100 terminals where 25x 80 chars screen. Nowadays, even on a 15" laptop, I can see around 150 chars on an edited file (in eclipse), even if the edited file is not full screen (ie, I have the package explorer on the left and the Outilne on the right). 120 is really a good limit.
