I've tested the scripts on the Mac env just now, there is no problem of them.
Thanks Jiajia -----Original Message----- From: Zheng, Kai [mailto:[email protected]] Sent: Tuesday, September 08, 2015 5:27 AM To: [email protected] Subject: RE: [VOTE] Release Apache Kerby 1.0.0-RC1 Hi Emmanuel, Would you let know if any more concern in your side about the scripts? Thanks. For the mac support, as we lack the environment it's not convenient for my side to support the platform. Hope we can get issue report/fixup contribution later even after the release in this aspect. Just a reminding. I know you're busy. :) Regards, Kai -----Original Message----- From: Zheng, Kai Sent: Monday, September 07, 2015 8:44 AM To: [email protected] Subject: RE: [VOTE] Release Apache Kerby 1.0.0-RC1 >> the file end line must be converted to \n only. I thought the scripts for *nix are correctly ended with \n only. Anyway, I just checked it again and ensured that. >> don't use !/bin/bash. This is very specific, not all the X boxes have bash >> installed. Use /bin/sh instead I changed to " #!/usr/bin/env bash" instead for flexible. It's not rare to rely on bash in today's world. >> in if [ $var=="-D" ], you have to use " around $var : [ "$var"=="-D" ] I changed to X"$var" == X"-D", is this your meaning? Looks like we don't have a mac to try the scripts. Would anyone help with this? It could be a simple try, since the scripts are very simple and the called codes are in Java. Thanks. Below is the fix, would you help please review? Thanks. commit 4cc13b91535a393fdf4ef60098a8204a66f3d84c Author: drankye <[email protected]> Date: Mon Sep 7 16:30:57 2015 +0800 Minor fixup for scripts for *nix Regards, Kai -----Original Message----- From: Emmanuel Lécharny [mailto:[email protected]] Sent: Sunday, September 06, 2015 10:38 PM To: [email protected] Subject: Re: [VOTE] Release Apache Kerby 1.0.0-RC1 Le 06/09/15 15:32, Li, Jiajia a écrit : > Hi Kai, > I think you are right because it's ok on linux when I use the trunk code to > run. There are a few bad thing sin the shell scripts : - obviously, the file end line must be converted to \n only. There are scripts to do that on linux - don't use !/bin/bash. This is very specific, not all the X boxes have bash installed. Use /bin/sh instead - in if [ $var=="-D" ], you have to use " around $var : [ "$var"=="-D" ] I suggest that the scripts are tested on various X box flavors (linux, mac OSX, etc).
