That's awesome, thanks Kai. I've been tied up on another project (getting myvd integrated with apacheds-2.0.0-m20) but I'm hoping to dive back in this weekend
Thanks Marc On Nov 20, 2015 1:25 AM, "Zheng, Kai" <[email protected]> wrote: > Steve and Marc, > > It's done, along with some other things. Please update to the latest codes. > 1. Added group to options and pick kdc flag related ones by group; > 2. Added requested some kdc flags, like RENEWABLE, RENEWABLE_OK and etc.; > 3. Not only for AS_REQ/TGT, but also for TGS_REQ/SGT; > 4. Some refactoring. > > Regards, > Kai > > -----Original Message----- > From: Zheng, Kai [mailto:[email protected]] > Sent: Friday, November 20, 2015 9:53 AM > To: [email protected]; Steve Moyer <[email protected]> > Subject: RE: Categorize KrbOption by adding group info > > Don't worry, I'll take this. > > Regards, > Kai > > -----Original Message----- > From: Steve Moyer [mailto:[email protected]] > Sent: Friday, November 20, 2015 9:23 AM > To: [email protected] > Subject: Re: Categorize KrbOption by adding group info > > I like the idea of groups in KrbOption ... it felt a little too dangerous > simply matching names but matched names and the appropriate group should be > safe. > > I might get to this change tomorrow but I'm working on another related > project at the moment. > > Steve > > -- > > “The mark of the immature man is that he wants to die nobly for a cause, > while the mark of the mature man is that he wants to live humbly for one.” > - Wilhelm Stekel > > ----- Original Message ----- > From: "Zheng, Kai" <[email protected]> > To: [email protected] > Sent: Thursday, November 19, 2015 7:44:48 PM > Subject: Categorize KrbOption by adding group info > > Hi Steve, > > Ref. https://issues.apache.org/jira/browse/DIRKRB-458 you're going to add > about 15 KDC flags into KrbOption. As we discussed it sounds reasonable. > Now here I'm considering it may be good to categorize them or easily > identify them as 'kdc flags', thus it would be much elegant to pick them up > and transform them to KdcRequest. How about adding a 'group' field to the > KrbOption enum? It could be done while you make the changes or we can do it > separately. Thanks. > > Also welcome any others' feedback. Thanks. > > Regards, > Kai >
