Hi Yan, Can you browse the reported findbug issues and pick up the DOES-MAKE-SENSE ones to fix? As we have more important things to do, I would suggest we focus on the important things.
Kerby won't pretend to be perfect in current phase, but does want to make more sense to users. Thanks. Regards, Kai -----Original Message----- From: YanYan (JIRA) [mailto:[email protected]] Sent: Wednesday, January 06, 2016 5:21 PM To: [email protected] Subject: [jira] [Updated] (DIRKRB-408) Fix findbugs issues [ https://issues.apache.org/jira/browse/DIRKRB-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YanYan updated DIRKRB-408: -------------------------- Attachment: DIRKRB-408.patch Fix most bugs in the 5 modules in Description. However, there are 2 remaining bugs: {code} Unused field: org.apache.kerby.benchmark.generated.JsonBackendBenchmark_jmhType_B1.p000 {code} In fact, there are 2304 of this same kind of bugs. {code} new org.apache.kerby.kerberos.kerb.integration.test.Transport$Message(String, byte[]) may expose internal representation by storing an externally mutable object into Transport$Message.body {code} I have tried {{this.body = body.clone()}}, however, it makes an error when test. Pulling request link: [https://github.com/apache/directory-kerby/pull/5] > Fix findbugs issues > -------------------- > > Key: DIRKRB-408 > URL: https://issues.apache.org/jira/browse/DIRKRB-408 > Project: Directory Kerberos > Issue Type: Bug > Affects Versions: 1.0.0-RC2 > Reporter: Xu Yaning > Assignee: YanYan > Attachments: DIRKRB-408.patch > > > When the source code is built with findbugs, there are some bugs, mainly in > benchmark module, json-backend module, integration-test module, kerb-util > module and kdc-tool module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
