Hi Kai,
Thanks for your advises, I will try to refactor the code.

Thanks
Jiajia

-----Original Message-----
From: Zheng, Kai [mailto:[email protected]] 
Sent: Saturday, January 09, 2016 10:14 AM
To: [email protected]
Subject: RE: About KdcRequest

By the way, DhClient/DhServer would be better renamed. How about 
DiffieHellmanClient/DiffieHellmanServer? Still, the "client/server" isn't good 
but any idea? Thanks.

-----Original Message-----
From: Zheng, Kai [mailto:[email protected]] 
Sent: Saturday, January 09, 2016 10:08 AM
To: [email protected]
Subject: About KdcRequest

Hi Jiajia,

I noticed the following line and related codes in KdcRequest.

private DhClient dhClient;

In my understanding, it should be only for PKINIT in DH case. Would you mind 
refactoring the codes and moving them to the mechanism specific scope (better 
to be in PkinitPreauth plugin). Thanks.

Regards,
Kai

Reply via email to