On 12/17/18 9:05 AM, Li, Jiajia wrote: > Thanks for the serious review. > >> The release includes binary artifacts of has-dist [1] which includes many >> third-party libraries, but the required license/notice files are missing in >> those dist packages. > > It's because N&L are not included in assembly.xml, I've fixed in the pull > request[1] > >> The dist archives also include the jdk.tools-1.8.jar which I assume we are >> not allowed to distribute. It's a system dependency from >> hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it? > > I've checked Hadoop does not include jdk.tool in distribution, I've excluded > it in [1] > >> PS: Dist packages of kdc-dist and tool-dist were not generated because their >> pom.xml use a Maven profile "-Pdist" which probably was not enabled during >> release build, but has-dist pom.xml does not inlude such a profile so >> artifacts were built and deployed. > > I've added the "dist" Maven profile in has-dist pom.xml in [1] > > Could you have a look at the pull request?
Looks good to me. Please feel free to include the binary dist packages in the release if they are useful for users. Other projects also include such. We just need to be more careful with the legal requirements. Kind Regards, Stefan
