Author: mickw Date: 2006-04-05 16:14:15 +0200 (Wed, 05 Apr 2006) New Revision: 2721
Modified: trunk/src/java/no/schibstedsok/front/searchportal/filters/MD5ProtectedParametersFilter.java Log: Pretty error page for MD5 failures. Modified: trunk/src/java/no/schibstedsok/front/searchportal/filters/MD5ProtectedParametersFilter.java =================================================================== --- trunk/src/java/no/schibstedsok/front/searchportal/filters/MD5ProtectedParametersFilter.java 2006-04-05 12:19:27 UTC (rev 2720) +++ trunk/src/java/no/schibstedsok/front/searchportal/filters/MD5ProtectedParametersFilter.java 2006-04-05 14:14:15 UTC (rev 2721) @@ -15,26 +15,26 @@ * @author <a href="mailto:[EMAIL PROTECTED]">Magnus Eklund</a> * @version <tt>$Revision$</tt> */ -public class MD5ProtectedParametersFilter implements Filter { +public final class MD5ProtectedParametersFilter implements Filter { private Map protectedParameters; private MD5Generator digestGenerator; - private static Log log = LogFactory.getLog(MD5ProtectedParametersFilter.class); + private static final Log LOG = LogFactory.getLog(MD5ProtectedParametersFilter.class); public void init(FilterConfig filterConfig) throws ServletException { protectedParameters = new HashMap(); - String secret = filterConfig.getInitParameter("secret"); - String parameters = filterConfig.getInitParameter("protectedParameters"); + final String secret = filterConfig.getInitParameter("secret"); + final String parameters = filterConfig.getInitParameter("protectedParameters"); - Boolean t = Boolean.TRUE; + final Boolean t = Boolean.TRUE; - String[] p = parameters.split(","); + final String[] p = parameters.split(","); for (int i = 0; i < p.length; i++) { - String parameter = p[i]; - log.info("Adding " + parameter + " as protected parameter"); + final String parameter = p[i]; + LOG.info("Adding " + parameter + " as protected parameter"); protectedParameters.put(parameter, t); } @@ -42,24 +42,25 @@ } public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, FilterChain filterChain) throws IOException, ServletException { - Enumeration e = servletRequest.getParameterNames(); + final Enumeration e = servletRequest.getParameterNames(); + while (e.hasMoreElements()) { - String parameterName = (String) e.nextElement(); + final String parameterName = (String) e.nextElement(); - if (log.isDebugEnabled()) { - log.debug("Checking to see if " + parameterName + " is protected"); + if (LOG.isDebugEnabled()) { + LOG.debug("Checking to see if " + parameterName + " is protected"); } if (protectedParameters.containsKey(parameterName)) { - log.debug(parameterName + " is protected"); + LOG.debug(parameterName + " is protected"); - String md5_parameter = servletRequest.getParameter(parameterName + "_x"); + final String md5_parameter = servletRequest.getParameter(parameterName + "_x"); if (md5_parameter == null || !digestGenerator.validate(servletRequest.getParameter(parameterName), md5_parameter)) { HttpServletResponse response = (HttpServletResponse) servletResponse; - response.sendError(HttpServletResponse.SC_BAD_REQUEST); + response.sendError(HttpServletResponse.SC_NOT_FOUND); return; } } _______________________________________________ Kernel-commits mailing list [email protected] http://sesat.no/mailman/listinfo/kernel-commits
