Author: sshafroi
Date: 2008-11-05 09:22:53 +0100 (Wed, 05 Nov 2008)
New Revision: 6904

Modified:
   
trunk/generic.sesam/velocity-directives/src/main/java/no/sesat/search/view/velocity/FaviconDirective.java
Log:
Log pollution: FaviconDirective: #favicon - wrong number of arguments

missing else between 1 and 2 argument test, so all 1 argument usage would 
result in a miss on 2 arguments and therefor an warning was printed out.



Modified: 
trunk/generic.sesam/velocity-directives/src/main/java/no/sesat/search/view/velocity/FaviconDirective.java
===================================================================
--- 
trunk/generic.sesam/velocity-directives/src/main/java/no/sesat/search/view/velocity/FaviconDirective.java
   2008-11-05 07:38:01 UTC (rev 6903)
+++ 
trunk/generic.sesam/velocity-directives/src/main/java/no/sesat/search/view/velocity/FaviconDirective.java
   2008-11-05 08:22:53 UTC (rev 6904)
@@ -73,8 +73,7 @@
 
         if (argCount == 1) {
             writer.write("<link href=\"" + resolvedPath + "\" rel=\"shortcut 
icon\" type=\"image/gif\" />");
-        }
-        if (argCount == 2) {
+        } else if (argCount == 2) {
             writer.write("<link href=\"" + resolvedPath + "\" " + 
getArgument(context, node, 1) + "/>");
         }
         else{

_______________________________________________
Kernel-commits mailing list
[email protected]
http://sesat.no/mailman/listinfo/kernel-commits

Reply via email to