> I'm not quite sure I understand what you mean. What I've been playing > with is adding a paging-navigation-id attribute to CommandConfig, > which will be used if set. Are we on the same page? ;) > > So views.xml looks like: > > <navigation id="offset"> > <result-paging id="addressOffset" command-name="address" > page-size="15" number-of-pages="10"/> > <result-paging id="whiteOffset" command-name="white" > page-size="15" number-of-pages="10"/> > <result-paging id="yellowOffset" command-name="yellow" > page-size="15" number-of-pages="10"/> > </navigation> > > and modes.xml looks like: > > <catalogue-command id="yellow" [...] > paging-navigation-id="yellowOffset"/>
Correct, but using a navigation id rather than a command id.
For example:
<result-paging id="nav1Offset" command-name="address" page-size="15"
number-of-pages="10"/>
<result-paging id="nav2Offset" command-name="white" page-size="15"
number-of-pages="10"/>
<result-paging id="nav3Offset" command-name="yellow" page-size="15"
number-of-pages="10"/>
since each result-paging refers to the command names already (allowing
that command-name attribute can contain a comma-seperated list of
commands).
Each command in modes instead has a offset-parameter attribute. The
UrlGenerator for the navigator detects this and fills it out
appropriately.
So it would be possible to use one result-paging for multiple commands
as well, or just individual result-paging as you have described.
This approach means that you don't need to reference views-xml stuff
from modes.xml, which we're aiming for - a clean encapsulation of the
business logic away from the any particular presentation.
> Anyways, since this forces changes in AbstractSearchCommand (and other
> classes) in SESAT I'm assuming this won't be in until 2.18. Am I right
> assuming this? I've created SKER4785 and set fix version to 2.18,
> please move to 2.17 if you think that's ok. ;)
I'll update it so with the former info. ok?
but it won't be 2.17 i can say for sure.
~mck
--
"If you are distressed by anything external, the pain is not due to the
thing itself, but to your estimate of it. This you have the power to
revoke." Marcus Aurelius
| semb.wever.org | sesat.no | sesam.no |
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Kernel-development mailing list [email protected] http://sesat.no/mailman/listinfo/kernel-development
