Activity report on

  *[JIRA] Bug SKER4937 - Query parsing failes when given (1 (2 3) 4)*

  Scarab Link: http://sesat.no/scarab/issues/id/SKER4937
  Module: Sesat> Kernel


  Activity generated by Håvard Frøiland ([EMAIL PROTECTED]) at 07/16/2008 14:54

  *Reasons for the changes*


  *Attribute changes*
  - Remaining Estimate: 1 ()
  - Status: In Progress (Open)
  - Original Time Estimate: 5 ()
  - Total Time Spent: 5 ()

-------------------------------------------------------------------------------
  *Comments*
  - By Håvard Frøiland - 07/16/2008 14:56 ---
  "Suggested patch that fixes:

((1))
(1 (1) 1)

and more combinations.
<pre>
--- query-api/src/main/javacc/QueryParserImpl.jj        (revision 6739)
+++ query-api/src/main/javacc/QueryParserImpl.jj        (working copy)
@@ -262,6 +262,8 @@
 }{
     ("("(clause = hiddenOrOperation())")") { try{return 
clause;}finally{exitMethod();} }
     |
+    ("("(clause = orOperation())")") { try{return 
clause;}finally{exitMethod();} }
+    |
     ((left = strongJoinPrecedence())<OR>(right = looseJoinPrecedence()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
 }
@@ -294,7 +296,7 @@
     ((left = leafPrecedence())(right = hiddenOrOperation()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
     |
-    ((left = strongJoinPrecedence())(right = looseJoinPrecedence()))
+    ((left = looseJoinPrecedence())(right = looseJoinPrecedence()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
     |
     // Not really an OR clause. Just () wrapped around something else. 
Therefore ignore the ()'s
</pre>"

  - By Håvard Frøiland - 07/16/2008 14:57 ---
  "Suggested patch that fixes:

((1))
(1 (1) 1)

and more combinations.
<pre>
--- query-api/src/main/javacc/QueryParserImpl.jj        (revision 6739)
+++ query-api/src/main/javacc/QueryParserImpl.jj        (working copy)
@@ -262,6 +262,8 @@
 }{
     ("("(clause = hiddenOrOperation())")") { try{return 
clause;}finally{exitMethod();} }
     |
+    ("("(clause = orOperation())")") { try{return 
clause;}finally{exitMethod();} }
+    |
     ((left = strongJoinPrecedence())<OR>(right = looseJoinPrecedence()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
 }
@@ -294,7 +296,7 @@
     ((left = leafPrecedence())(right = hiddenOrOperation()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
     |
-    ((left = strongJoinPrecedence())(right = looseJoinPrecedence()))
+    ((left = looseJoinPrecedence())(right = looseJoinPrecedence()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
     |
     // Not really an OR clause. Just () wrapped around something else. 
Therefore ignore the ()'s
</pre>"

  - By Håvard Frøiland - 07/16/2008 14:58 ---
  "Suggested patch that fixes:

((1))
(1 (1) 1)

and more combinations.
<pre>
--- query-api/src/main/javacc/QueryParserImpl.jj        (revision 6739)
+++ query-api/src/main/javacc/QueryParserImpl.jj        (working copy)
@@ -262,6 +262,8 @@
 }{
     ("("(clause = hiddenOrOperation())")") { try{return 
clause;}finally{exitMethod();} }
     |
+    ("("(clause = orOperation())")") { try{return 
clause;}finally{exitMethod();} }
+    |
     ((left = strongJoinPrecedence())<OR>(right = looseJoinPrecedence()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
 }
@@ -294,7 +296,7 @@
     ((left = leafPrecedence())(right = hiddenOrOperation()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
     |
-    ((left = strongJoinPrecedence())(right = looseJoinPrecedence()))
+    ((left = looseJoinPrecedence())(right = looseJoinPrecedence()))
         { try{return 
context.createOrClause(left,right);}finally{exitMethod();} }
     |
     // Not really an OR clause. Just () wrapped around something else. 
Therefore ignore the ()'s
</pre>"
_______________________________________________
Kernel-issues mailing list
[email protected]
http://sesat.no/mailman/listinfo/kernel-issues

Svar til