Activity report on

  *[JIRA] Bug SKER4947 - StringChopper will not handle cdata*

  Scarab Link: http://sesat.no/scarab/issues/id/SKER4947
  Module: Sesat> Kernel


  Activity generated by Håvard Frøiland ([EMAIL PROTECTED]) at 08/18/2008 15:22

  *Reasons for the changes*


  *Comments*
  - By Håvard Frøiland - 08/18/2008 15:35 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:27 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:26 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:22 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:33 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:31 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:34 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:35 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:27 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:22 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:25 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:34 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"

  - By Håvard Frøiland - 08/18/2008 15:32 ---
  "{code}The patch that Endre supplied fixed some of the problems. It fixed the 
<? heading tag, and had a quick fix for cdata tags. The problem is that cdata 
can include invalid xml.

The patch that was submitted:

-    private static final Pattern openTag = Pattern.compile("<[^<]+>");
+    private static final Pattern openTag = Pattern.compile("<[^\\?!][^<]+>");
the escaping of ? is not needed, and including it will actually include \\\ in 
the set.

Another thing that might be a good change, is to look for the tag like this 
<[^?!].+>? (using the non greedy way) instead of looking for the start of the 
next tag.
{code}"
_______________________________________________
Kernel-issues mailing list
[email protected]
http://sesat.no/mailman/listinfo/kernel-issues

Svar til