Hello Stefan, or anyone else affected,

Accepted ubuntu-fan into artful-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/ubuntu-
fan/0.12.8~17.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-artful to verification-done-artful. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-artful. In either case, details of your
testing will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to ubuntu-fan in Ubuntu.
https://bugs.launchpad.net/bugs/1728050

Title:
  fanatic enable-fan does not clean up config after failed bringup

Status in ubuntu-fan package in Ubuntu:
  Fix Released
Status in ubuntu-fan source package in Xenial:
  Fix Committed
Status in ubuntu-fan source package in Zesty:
  Fix Committed
Status in ubuntu-fan source package in Artful:
  Fix Committed

Bug description:
  SRU Justification (for Artful/Zesty/Xenial):

  Impact:
  "fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge. 
However it is possible that this returns with an error and in that case fanatic 
must undo previously done configuration changes or otherwise any following 
attempt to run enable-fan will incorrectly believe the bridge is up and do 
nothing.

  Fix:
  Adding a remove config stage if the call to fanctl returns with an error.

  Testcase:
    [fan is installed but not enabled]
    - sudo flock -x /run/xtables.lock sleep 300
    - fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?

  Note: It seems in Artful, the default for iptables is to wait until
  the lock is released (without -w) so the test here won't work without
  adding -w to all iptables calls in fanctl. :/

  Regression potential:
  Cleanup called only on failure and the used function is also used in fanatic 
disable-fan. -> Low

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1728050/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to