This bug was fixed in the package ubuntu-fan - 0.12.8~16.04.1
---------------
ubuntu-fan (0.12.8~16.04.1) xenial; urgency=medium
* fanatic: Optionally provide DNS server for docker test (LP:
#1732717)
ubuntu-fan (0.12.7~16.04.1) xenial; urgency=medium
* fanctl: cmd_up needs to proparate scan_config errors (LP: #1719644)
* fanatic: Clean up config if bringup fails (LP: #1728050)
ubuntu-fan (0.12.6~16.04.1) xenial; urgency=medium
[ 0.12.5 ]
* DEP8: Fix LXD default interface detection (LP: #1732739)
* fanctl: return error on fail_up (LP: #1719644)
[ 0.12.6 ]
* fanatic: Add short success delay to nc_send (LP: #1721352)
* fanatic: Catch test preparation steps failing (LP: #1735183)
* fanatic: Add DNS checks to local-test preparation (LP: #1732747)
ubuntu-fan (0.12.4~16.04.1) xenial; urgency=medium
[ Andy Whitcroft ]
* fanctl.8: fix interfane type (LP: #1584845)
* debian/control: fix use of obsolete > operator (LP: #1714969)
* fanctl: only bring up enabled Fan Networks in --auto mode (LP: #1707610)
* fanctl: correctly specify local interface specific config (LP: #1707610)
* fanatic: recast advanced commands as non-interactive (LP: #1714966)
* fanatic: fix spelling in primary help (LP: #1714966)
* fanatic: fix references to fanatic manual page (LP: #1714966)
[ Stefan Bader ]
* fanatic: fix local testing and improve docker test (LP: #1714969)
* fanatic: Support nc -N option (LP: #1714969)
* fanatic: Prevent error message without docker installed (LP: #1714969)
* fanatic: Supply LXD storage if needed (LP: #1714969)
* dep8: Add LXD auto-test (LP: #1714969)
* fanatic: Fix typo in progress output (LP: #1714966)
* README: Refresh documentation (LP: #1714966)
* fanctl.8: Refresh documentation (LP: #1714966)
* fanatic.8: Refresh documentation (LP: #1714966)
* fanatic.8: Reword advanced to non-interactive usage (LP: #1714966)
* DEP8: lxd: Suppress stderr on profile list (LP: #1714969)
-- Stefan Bader <stefan.ba...@canonical.com> Wed, 29 Nov 2017 16:17:26
+0100
** Changed in: ubuntu-fan (Ubuntu Xenial)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to ubuntu-fan in Ubuntu.
https://bugs.launchpad.net/bugs/1728050
Title:
fanatic enable-fan does not clean up config after failed bringup
Status in ubuntu-fan package in Ubuntu:
Fix Released
Status in ubuntu-fan source package in Xenial:
Fix Released
Status in ubuntu-fan source package in Zesty:
Fix Released
Status in ubuntu-fan source package in Artful:
Fix Released
Bug description:
SRU Justification (for Artful/Zesty/Xenial):
Impact:
"fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge.
However it is possible that this returns with an error and in that case fanatic
must undo previously done configuration changes or otherwise any following
attempt to run enable-fan will incorrectly believe the bridge is up and do
nothing.
Fix:
Adding a remove config stage if the call to fanctl returns with an error.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?
Note: It seems in Artful, the default for iptables is to wait until
the lock is released (without -w) so the test here won't work without
adding -w to all iptables calls in fanctl. :/
Regression potential:
Cleanup called only on failure and the used function is also used in fanatic
disable-fan. -> Low
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1728050/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
