Public bug reported: SRU Justification
Impact: Currently, shiftfs maintains a kmem cache for struct shiftfs_file_info which stashes away a struct path and the struct file for the underlay. The path however is never used anywhere so the struct shiftfs_file_info and therefore the whole kmem cache can go away. This removes code and makes the whole logic simpler to understand and reason about. Fix: Remove the kmem cache for struct shiftfs_file_info and struct shiftfs_file_info itself and move to the same model as overlayfs and just stash away the struct file for the underlay in file->private_data of the shiftfs struct file Regression Potential: Limited to shiftfs. The basic logic is unchanged. It is just simplified so regression potential should be fairly low. Test Case: Tested with LXD on a kernel with the patch applied and running various standard workloads without any observable regressions. Target Kernels: All LTS kernels with support for shiftfs. ** Affects: linux (Ubuntu) Importance: Undecided Status: Incomplete -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1846265 Title: shiftfs: rework how shiftfs opens files Status in linux package in Ubuntu: Incomplete Bug description: SRU Justification Impact: Currently, shiftfs maintains a kmem cache for struct shiftfs_file_info which stashes away a struct path and the struct file for the underlay. The path however is never used anywhere so the struct shiftfs_file_info and therefore the whole kmem cache can go away. This removes code and makes the whole logic simpler to understand and reason about. Fix: Remove the kmem cache for struct shiftfs_file_info and struct shiftfs_file_info itself and move to the same model as overlayfs and just stash away the struct file for the underlay in file->private_data of the shiftfs struct file Regression Potential: Limited to shiftfs. The basic logic is unchanged. It is just simplified so regression potential should be fairly low. Test Case: Tested with LXD on a kernel with the patch applied and running various standard workloads without any observable regressions. Target Kernels: All LTS kernels with support for shiftfs. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1846265/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp