The patches seem to fail on kernel 5.4. This is running on Debian with
5.4.0-2 packaged kernel, and using Stefan's DKMS package:

DKMS make.log for fixed-cdc-ether-ncm-0.1 for kernel 5.4.0-2-amd64 (x86_64)
Thu Jan 16 15:22:17 CET 2020
make: Entering directory '/usr/src/linux-headers-5.4.0-2-amd64'
  AR      /var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/built-in.a
  CC [M]  
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/cdc_ether.o
  CC [M]  /var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/cdc_ncm.o
  CC [M]  /var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/cdc_mbim.o
  CC [M]  /var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.o
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c: In 
function 'build_dma_sg':
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c:1339:31: 
error: initialization of 'struct skb_frag_struct *' from incompatible pointer 
type 'skb_frag_t *' {aka 'struct bio_vec *'} 
[-Werror=incompatible-pointer-types]
 1339 |   struct skb_frag_struct *f = &skb_shinfo(skb)->frags[i];
      |                               ^
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c:1341:30: 
error: passing argument 1 of 'skb_frag_size' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
 1341 |   total_len += skb_frag_size(f);
      |                              ^
      |                              |
      |                              struct skb_frag_struct *
In file included from 
/usr/src/linux-headers-5.4.0-2-common/include/linux/if_ether.h:19,
                 from 
/usr/src/linux-headers-5.4.0-2-common/include/uapi/linux/ethtool.h:19,
                 from 
/usr/src/linux-headers-5.4.0-2-common/include/linux/ethtool.h:18,
                 from 
/usr/src/linux-headers-5.4.0-2-common/include/linux/netdevice.h:37,
                 from 
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c:37:
/usr/src/linux-headers-5.4.0-2-common/include/linux/skbuff.h:325:60: note: 
expected 'const skb_frag_t *' {aka 'const struct bio_vec *'} but argument is of 
type 'struct skb_frag_struct *'
  325 | static inline unsigned int skb_frag_size(const skb_frag_t *frag)
      |                                          ~~~~~~~~~~~~~~~~~~^~~~
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c:1342:33: 
error: dereferencing pointer to incomplete type 'struct skb_frag_struct'
 1342 |   sg_set_page(&urb->sg[i + s], f->page.p, f->size,
      |                                 ^~
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c: In 
function 'usbnet_bh':
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c:1530:4: 
warning: this statement may fall through [-Wimplicit-fallthrough=]
 1530 |    kfree(entry->urb->sg);
      |    ^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.c:1531:3: 
note: here
 1531 |   case rx_cleanup:
      |   ^~~~
cc1: some warnings being treated as errors
make[5]: *** [/usr/src/linux-headers-5.4.0-2-common/scripts/Makefile.build:271: 
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb/usbnet.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [/usr/src/linux-headers-5.4.0-2-common/scripts/Makefile.build:514: 
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net/usb] Error 2
make[3]: *** [/usr/src/linux-headers-5.4.0-2-common/scripts/Makefile.build:514: 
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers/net] Error 2
make[2]: *** [/usr/src/linux-headers-5.4.0-2-common/scripts/Makefile.build:514: 
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build/drivers] Error 2
make[1]: *** [/usr/src/linux-headers-5.4.0-2-common/Makefile:1665: 
/var/lib/dkms/fixed-cdc-ether-ncm/0.1/build] Error 2
make: *** [/usr/src/linux-headers-5.4.0-2-common/Makefile:179: sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-5.4.0-2-amd64'

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1779173

Title:
  Dell D6000 dock lacks multicast Ethernet functionality

Status in Linux:
  Confirmed
Status in linux package in Ubuntu:
  Triaged

Bug description:
  Dell D6000 exposes a CDC_NCM device for Ethernet traffic. However,
  multicast Ethernet traffic is not processed making IPv6 not
  functional. Other services, like mDNS used for LAN service discovery
  are also hindered.

  The actual reason is that CDC_NCM driver was not processing requests
  to filter (admit) multicast traffic. I provide two patches to the
  linux kernel that admit all Ethernet multicast traffic whenever a
  multicast group is being joined.

  The solution is not optimal, as it makes the system receive more
  traffic than that strictly needed, but otherwise this only happens
  when the computer is connected to a dock and thus is running on AC
  power. I believe it is not worth the hassle to join only the requested
  groups. This is the same that is done in the CDN_ETHER driver.

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1779173/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to