Public bug reported:
The bellow upstream commit fixes a bug in Ktls feature.
It is applied cleanly above the ubuntu-focal tree and passed basic sanity
testing.
We would like it to be backported ubuntu-focal
Thanks,
Amir
commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8
Author: Tariq Toukan <tar...@mellanox.com>
Date: Mon Jun 22 23:26:04 2020 +0300
net: Do not clear the sock TX queue in sk_set_socket()
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
Signed-off-by: Tariq Toukan <tar...@mellanox.com>
Reviewed-by: Boris Pismenny <bor...@mellanox.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
** Affects: linux (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1889625
Title:
Bug fix for ktls feature
Status in linux package in Ubuntu:
New
Bug description:
The bellow upstream commit fixes a bug in Ktls feature.
It is applied cleanly above the ubuntu-focal tree and passed basic sanity
testing.
We would like it to be backported ubuntu-focal
Thanks,
Amir
commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8
Author: Tariq Toukan <tar...@mellanox.com>
Date: Mon Jun 22 23:26:04 2020 +0300
net: Do not clear the sock TX queue in sk_set_socket()
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
Signed-off-by: Tariq Toukan <tar...@mellanox.com>
Reviewed-by: Boris Pismenny <bor...@mellanox.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889625/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
